Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/fix locales #66

Merged
merged 1 commit into from
May 30, 2023
Merged

Bug/fix locales #66

merged 1 commit into from
May 30, 2023

Conversation

BelligerentBash
Copy link
Contributor

@BelligerentBash BelligerentBash commented Mar 12, 2023 •
edited
Loading

Describe Pull request
This PR does the following:

  • fixes the grammar of the messages used in locales/en.lua (English)
  • removes two unused strings from all locales one_bus_active and drop_off_passengers which appear to have be erroneously leftover from bus job? Locals typo?  #61
  • changes 'depreciation' to 'debit' in the locale and appropriate functions to be consistent

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? yes. tested on the latest qb-core installation
  • Does your code fit the style guidelines? yes
  • Does your PR fit the contribution guidelines? yes

@BelligerentBash BelligerentBash mentioned this pull request Mar 12, 2023
Closed
@GhzGarage GhzGarage merged commit 7ea9199 into qbcore-framework:main May 30, 2023
@BelligerentBash BelligerentBash deleted the bug/fix-locales branch October 10, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BelligerentBash BelligerentBash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BelligerentBash @GhzGarage