Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw LottieError if the fetch response is not ok #196

Merged
merged 2 commits into from
Sep 7, 2023
Merged

throw LottieError if the fetch response is not ok #196

merged 2 commits into from
Sep 7, 2023

Conversation

SkoebaSteve
Copy link
Contributor

This should patch this change, I'm so used to our NetworkManager throwing that I forgot that fetch by itself doesn't throw an error so we need to do this by checking the response

herzzanu
herzzanu approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@herzzanu herzzanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@SkoebaSteve SkoebaSteve merged commit 7eb6ad1 into main Sep 7, 2023
10 checks passed
@mrloop mrloop added the enhancement New feature or request label Sep 7, 2023
@SkoebaSteve SkoebaSteve self-assigned this Sep 7, 2023
@michelegera michelegera deleted the fetch-ok branch December 28, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herzzanu herzzanu herzzanu approved these changes

@poulet42 poulet42 poulet42 approved these changes

Assignees

@SkoebaSteve SkoebaSteve

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SkoebaSteve @herzzanu @poulet42 @mrloop