New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry tracing #118

Merged

vmercierfr merged 8 commits into main from otel

Mar 15, 2024

Collaborator

vmercierfr commented Jan 31, 2024 •

edited

Loading

Objective

Add OpenTelemetry tracing

Why

Tracing help to troubleshoot and investigate exporter performances.

screenshot 2024-01-31 at 23 51 21

We'll leverage on this tracing to investigate and fix bugs tied to AWS APIs call (e.g. #96)

How

Add OpenTelemetry tracing
Add --enable-otel parameter (or enable-otel in configuration file)

Release plan

Merge this PR

vmercierfr added the enhancement label

Collaborator Author

vmercierfr commented Jan 31, 2024

#sre

Collaborator Author

vmercierfr commented Jan 31, 2024 •

edited

Loading

@mcorbin @dcupif I'll be happy to have your insight on this feature

vmercierfr force-pushed the otel branch 2 times, most recently from d4e13e1 to 80d5a41 Compare

January 31, 2024 22:59

ortizjavier reviewed

View reviewed changes

README.md Show resolved Hide resolved

ortizjavier reviewed

View reviewed changes

internal/app/cloudwatch/usage.go Show resolved Hide resolved

ortizjavier reviewed

View reviewed changes

internal/app/servicequotas/servicequotas.go Outdated Show resolved Hide resolved

ortizjavier reviewed

View reviewed changes

internal/app/servicequotas/servicequotas.go Outdated Show resolved Hide resolved

ortizjavier reviewed

View reviewed changes

internal/app/servicequotas/servicequotas.go Outdated Show resolved Hide resolved

vmercierfr force-pushed the otel branch 2 times, most recently from ffc3145 to bcfcb06 Compare

February 1, 2024 11:04

vmercierfr requested review from victorboissiere, mcorbin, dcupif and qfritz

February 1, 2024 11:05

qfritz approved these changes

View reviewed changes

vmercierfr added this to the 0.6.0 milestone

vmercierfr force-pushed the otel branch 2 times, most recently from e0868a9 to 262ffe8 Compare

March 13, 2024 15:50

mcorbin reviewed

View reviewed changes

cmd/root.go Outdated Show resolved Hide resolved

mcorbin reviewed

View reviewed changes

internal/app/cloudwatch/usage.go Outdated Show resolved Hide resolved

mcorbin reviewed

View reviewed changes

internal/infra/http/server.go Outdated Show resolved Hide resolved

mcorbin reviewed

View reviewed changes

internal/app/rds/rds.go Outdated Show resolved Hide resolved

vmercierfr modified the milestones: 0.7.0, 0.8.0

dcupif approved these changes

View reviewed changes

Contributor

dcupif left a comment

LGTM but you probably should address Matthieu's comments before merging

internal/app/ec2/ec2.go Show resolved Hide resolved

vmercierfr force-pushed the otel branch 3 times, most recently from a267e71 to 067489f Compare

March 14, 2024 17:03

vmercierfr force-pushed the otel branch 3 times, most recently from aab9205 to cc5d3f6 Compare

March 15, 2024 08:46

vmercierfr added 8 commits

March 15, 2024 09:48


feat(tracing): Add OpenTelemetry tracing

40e87b2

Signed-off-by: Vincent Mercier <[email protected]>


chore(doc): Add OTEL parameter

56a5a81

Signed-off-by: Vincent Mercier <[email protected]>


chore(cloudwatch): Add OTEL trace

873d0e4

Signed-off-by: Vincent Mercier <[email protected]>


chore(ec2): Add OTEL trace

82e0505

Signed-off-by: Vincent Mercier <[email protected]>


chore(rds): Add OTEL trace

add5744

Signed-off-by: Vincent Mercier <[email protected]>

fix

8a53176

Signed-off-by: Vincent Mercier <[email protected]>


chore(servicequotas): Add OTEL trace

a0743a0

Signed-off-by: Vincent Mercier <[email protected]>


refact(trace): Move custom trace attributes to a trace package

f475a1a

Signed-off-by: Vincent Mercier <[email protected]>

vmercierfr force-pushed the otel branch from cc5d3f6 to f475a1a Compare

March 15, 2024 08:48

github-actions bot commented Mar 15, 2024

Package	Line Rate	Health
github.com/qonto/prometheus-rds-exporter/internal/app/cloudwatch	87%	✔
github.com/qonto/prometheus-rds-exporter/internal/app/ec2	85%	✔
github.com/qonto/prometheus-rds-exporter/internal/app/exporter	80%	➖
github.com/qonto/prometheus-rds-exporter/internal/app/rds	75%	➖
github.com/qonto/prometheus-rds-exporter/internal/app/servicequotas	51%	❌
github.com/qonto/prometheus-rds-exporter/internal/app/trace	100%	✔
github.com/qonto/prometheus-rds-exporter/internal/app/unit	100%	✔
Summary	80% (1014 / 1274)	➖

Minimum allowed line rate is 60%

vmercierfr merged commit e7d41d3 into main

12 checks passed

vmercierfr deleted the otel branch

April 3, 2024 08:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels