Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous of @internal #1287

Closed
gennadigennadigennadi opened this issue Nov 11, 2023 · 1 comment
Closed

Ambiguous of @internal #1287

gennadigennadigennadi opened this issue Nov 11, 2023 · 1 comment
Labels
bc-break someone works on

Comments

@gennadigennadigennadi
Copy link
Member

gennadigennadigennadi commented Nov 11, 2023 •
edited
Loading

Deptrac uses @interal as it's own layer config. Aka The class is only allowed to be used in it's layer.

The problem is, that it also has the community proved meaning of the class is "final" and should not be used by anyone else then the package itself.

Because of this we always recommend to register a services to exclude these warnings.

See #1220 and many more.

I would like to remove @internal and only support @deptrac-internal. And maybe also rename it to @deptrac-layer-internal, so it's usage is clear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bc-break someone works on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrickkusebauch @gennadigennadigennadi