-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option --report-uncovered placed before --config-file makes deptrac ignore the provided configuration file #1425
Comments
If I remember correctly the reason for this behaviour has something to do with sharing common configs over the commands. @dbrumann, @patrickkusebauch Am I right? |
A quick fix would be to use Maybe just revert this commit: qossmic/deptrac-src@703b212 ? |
Closes request #39741: qossmic/deptrac-shim: 1.0.2 -> qossmic/deptrac: 2.0.1 No functional change. CI should be happy. Notes: - "regex" configuration is now "value". - I could not make the "class" collector work, defaulting to "classLike". - Due to a bug [0], the `--report-uncovered` and `--fail-on-uncovered` flags MUST come after `--config-file`, or deptrac will not find the file and raise an error that it did not find `deptrac.yaml` (the default file). - There are still 7 existing core -> plugins violations, but for an unknown reason, deptrac does not see them on the CI: PermissionsManager: - Tuleap\Tracker\TrackerDuplicationUserGroupMapping PermissionsDao: - Tuleap\Tracker\TrackerDuplicationType - Tuleap\Tracker\TrackerDuplicationUserGroupMapping Tuleap\Reference\CrossReferenceManager: - Tuleap\Tracker\Artifact\Artifact - Tuleap\Tracker\Artifact\ArtifactsDeletion\DeletionContext Tuleap\Project\UGroups\XML\XMLUserGroup - Tuleap\Tracker\XML\XMLUser [0] qossmic/deptrac#1425 Change-Id: Ifc5d7ea1735d56cd3909b87f3130bd7189056162
Tested on: 2.0.1
Hello, while doing some tests on a project, I figured out that somehow, when placing the flag
--report-uncovered
(or--fail-on-uncovered
) before specifying the configuration file through the--config-file
option, this last one is ignored anddeptrac
tries to use the default configuration file instead.The problem doesn't occur for the
--no-cache
flag for instance but I've not tested the other ones.Examples:
Running
tools/vendor/bin/deptrac analyze --config-file=deptrac_hexagonal.yaml --report-uncovered
will works properly, with the following output:But running
tools/vendor/bin/deptrac analyze --report-uncovered --config-file=deptrac_hexagonal.yaml
will give me an error due todeptrac.yml
not being found:For additional information, I tested the same operation on another project where
qossmic/deptrac-shim:1.0.2
is installed instead and it seems to work without any issue.The text was updated successfully, but these errors were encountered: