Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub groups & Relay improvements #2260

Merged
merged 43 commits into from
Sep 14, 2023
Merged

Hub groups & Relay improvements #2260

merged 43 commits into from
Sep 14, 2023

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Sep 4, 2023

WIP.

Fixes #2234.

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

🦋 Changeset detected

Latest commit: 11580a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@quri/ui Patch
@quri/squiggle-components Patch
vscode-squiggle Patch
@quri/squiggle-lang Patch
@quri/prettier-plugin-squiggle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@berekuk berekuk temporarily deployed to Preview September 4, 2023 23:37 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 5:03am
quri-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 5:03am
squiggle-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 5:03am
squiggle-website ✅ Ready (Inspect) Visit Preview Sep 14, 2023 5:03am

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (00f5a6c) 73.06% compared to head (4d35439) 73.04%.
Report is 6 commits behind head on main.

❗ Current head 4d35439 differs from pull request most recent head 11580a4. Consider uploading reports for the commit 11580a4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   73.06%   73.04%   -0.02%     
==========================================
  Files         107      107              
  Lines        5349     5349              
  Branches     1026     1026              
==========================================
- Hits         3908     3907       -1     
- Misses       1433     1434       +1     
  Partials        8        8              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berekuk berekuk temporarily deployed to Preview September 5, 2023 23:38 — with GitHub Actions Inactive
@berekuk
Copy link
Collaborator Author

berekuk commented Sep 5, 2023

Member management UI requires two accounts to see, so here are screenshots; https://quri-hub-git-hub-groups-quantified-uncertainty.vercel.app/groups/testgroup

When user is not a member of a group:
Captura de pantalla 2023-09-05 a la(s) 17 28 36

When user is a member:
Captura de pantalla 2023-09-05 a la(s) 17 29 06

Invite dropdown:
Captura de pantalla 2023-09-05 a la(s) 17 29 31

Invite modal:
Captura de pantalla 2023-09-05 a la(s) 17 40 52

Pending invites:
Captura de pantalla 2023-09-05 a la(s) 17 32 57

Members can be deleted:
Captura de pantalla 2023-09-05 a la(s) 17 33 16

Pending invites can be canceled:
Captura de pantalla 2023-09-05 a la(s) 17 34 08

It's possible to change the role of members or pending invites:
Captura de pantalla 2023-09-05 a la(s) 17 34 30

Fail-safe against accidentally orphaning the group (also works when you try to delete the last owner):
Captura de pantalla 2023-09-05 a la(s) 17 35 07

Invite notification on group page:
Captura de pantalla 2023-09-05 a la(s) 17 36 18

Accepted:
Captura de pantalla 2023-09-05 a la(s) 17 36 39

After an invite has been declined, it's possible to send a new one. (Invite entry still stays in the database even after it's processed, for logs.)

Accepting an invite re-renders the page (by invalidating the page query). Unfortunately, since models/members tabs are currently not routes, this resets the page back to "Models" tab; this can be fixed later.

Also, right now it's still possible to invite an existing member. I should add a check for this in inviteUserToGroup mutation.

@berekuk
Copy link
Collaborator Author

berekuk commented Sep 5, 2023

Another note: I didn't implement some important error messages yet. Some mutations check for permissions by asking for conditions in Prisma create/update queries. Those checks fail with cryptic errors that are passed to the frontend.

@berekuk
Copy link
Collaborator Author

berekuk commented Sep 5, 2023

This also fixes #2243.
(do "fixes #number" actions work in comments? I'm not sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Groups in Hub
1 participant