-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hub groups & Relay improvements #2260
Conversation
🦋 Changeset detectedLatest commit: 11580a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2260 +/- ##
==========================================
- Coverage 73.06% 73.04% -0.02%
==========================================
Files 107 107
Lines 5349 5349
Branches 1026 1026
==========================================
- Hits 3908 3907 -1
- Misses 1433 1434 +1
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Member management UI requires two accounts to see, so here are screenshots; https://quri-hub-git-hub-groups-quantified-uncertainty.vercel.app/groups/testgroup When user is not a member of a group: Pending invites can be canceled: It's possible to change the role of members or pending invites: Fail-safe against accidentally orphaning the group (also works when you try to delete the last owner): Invite notification on group page: After an invite has been declined, it's possible to send a new one. (Invite entry still stays in the database even after it's processed, for logs.) Accepting an invite re-renders the page (by invalidating the page query). Unfortunately, since models/members tabs are currently not routes, this resets the page back to "Models" tab; this can be fixed later. Also, right now it's still possible to invite an existing member. I should add a check for this in |
Another note: I didn't implement some important error messages yet. Some mutations check for permissions by asking for conditions in Prisma create/update queries. Those checks fail with cryptic errors that are passed to the frontend. |
This also fixes #2243. |
WIP.
Fixes #2234.