Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Quarkus mDNS #270

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Introduce Quarkus mDNS #270

merged 4 commits into from
Sep 11, 2024

Conversation

melloware
Copy link
Contributor

@melloware melloware commented Sep 11, 2024

@melloware melloware marked this pull request as ready for review September 11, 2024 19:00
@melloware
Copy link
Contributor Author

@gastaldi feel free to fix anything i did wrong 😄

Copy link

github-actions bot commented Sep 11, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Running plan in the remote backend. Output will stream here. Pressing Ctrl-C
will stop streaming the logs, but will not stop the plan running remotely.

Preparing the remote plan...

The remote workspace is configured to work with configuration at
terraform-scripts relative to the target repository.

Terraform will upload the contents of the following directory,
excluding files or directories as defined by a .terraformignore file
at /home/runner/work/quarkiverse-devops/quarkiverse-devops/.terraformignore (if it is present),
in order to capture the filesystem context the remote workspace expects:
    /home/runner/work/quarkiverse-devops/quarkiverse-devops

To view this run in a browser, visit:
https://app.terraform.io/app/quarkiverse/quarkiverse-devops/runs/run-mRjL3YXsqfwX4EnN

Waiting for the plan to start...

Terraform v1.9.5
on linux_amd64
Initializing plugins and modules...

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_repository.quarkus_mdns will be created
  + resource "github_repository" "quarkus_mdns" {
      + allow_auto_merge            = false
      + allow_merge_commit          = true
      + allow_rebase_merge          = true
      + allow_squash_merge          = true
      + allow_update_branch         = true
      + archive_on_destroy          = true
      + archived                    = false
      + default_branch              = (known after apply)
      + delete_branch_on_merge      = true
      + description                 = "Quarkus mDNS extension - Multicast Domain Name System"
      + etag                        = (known after apply)
      + full_name                   = (known after apply)
      + git_clone_url               = (known after apply)
      + has_issues                  = true
      + homepage_url                = "https://docs.quarkiverse.io/quarkus-mdns/dev/"
      + html_url                    = (known after apply)
      + http_clone_url              = (known after apply)
      + id                          = (known after apply)
      + merge_commit_message        = "PR_TITLE"
      + merge_commit_title          = "MERGE_MESSAGE"
      + name                        = "quarkus-mdns"
      + node_id                     = (known after apply)
      + primary_language            = (known after apply)
      + private                     = (known after apply)
      + repo_id                     = (known after apply)
      + squash_merge_commit_message = "COMMIT_MESSAGES"
      + squash_merge_commit_title   = "COMMIT_OR_PR_TITLE"
      + ssh_clone_url               = (known after apply)
      + svn_url                     = (known after apply)
      + topics                      = [
          + "bonjour",
          + "discovery",
          + "mdns",
          + "quarkus-extension",
        ]
      + visibility                  = (known after apply)
      + vulnerability_alerts        = true
      + web_commit_signoff_required = false

      + security_and_analysis (known after apply)
    }

  # github_team.quarkus_mdns will be created
  + resource "github_team" "quarkus_mdns" {
      + create_default_maintainer = false
      + description               = "mdns team"
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "quarkiverse-mdns"
      + node_id                   = (known after apply)
      + parent_team_id            = "5344029"
      + parent_team_read_id       = (known after apply)
      + parent_team_read_slug     = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team_membership.quarkus_mdns["melloware"] will be created
  + resource "github_team_membership" "quarkus_mdns" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "melloware"
    }

  # github_team_repository.quarkus_mdns will be created
  + resource "github_team_repository" "quarkus_mdns" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "quarkus-mdns"
      + team_id    = (known after apply)
    }

Plan: 4 to add, 0 to change, 0 to destroy.

Pusher: @melloware, Action: pull_request, Workflow: Terraform

@gastaldi
Copy link
Member

Isn't the library named jmdns? Given that the extension is meant to support that library I think it will be better if it's called like it?

@melloware
Copy link
Contributor Author

melloware commented Sep 11, 2024

Well multicast DNS is a generic protocol the library is jmdns but this would give us flexibility to swap it out for a different library in the future. So I like to generically call it just mdns. Apple calls is Bonjour before the spec was released and renamed mDNS

@melloware
Copy link
Contributor Author

Its actually had many names in the past Bonjour/Avahi/Rendezvous/ZeroConf services

@gastaldi
Copy link
Member

Well multicast DNS is a generic protocol the library is jmdns but this would give us flexibility to swap it out for a different library in the future. So I like to generically call it just mdns. Apple calls is Bonjour before the spec was released and renamed mDNS

Right, I thought the extension was meant to provide native support for the jmdms library, but I guess that makes sense if the plan is to provide support for mDNS regardless if using this library or not

Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid work! Good job!

@gastaldi gastaldi merged commit 1255dfc into main Sep 11, 2024
2 checks passed
@gastaldi gastaldi deleted the melloware-mdns branch September 11, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Extension Proposal] automatically register an <application>.local domain when running in dev mode
2 participants