Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable external application on Aarch OCP #2068

Closed

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Oct 7, 2024

Summary

Tests for external applications requires a s2i.maven.remote.repository property to be defined, if running against snapshot builds. Lacking this in aarch jobs caused several failures in its tests.
Since we cannot use external S2I repo in aarch cluster RN, disabling these tests.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from mjurc October 7, 2024 15:29
@mocenas mocenas marked this pull request as draft October 8, 2024 09:12
@mocenas
Copy link
Contributor Author

mocenas commented Oct 8, 2024

I'm making this a draft. I have a feeling that we will need this annotation on more places, so it might be better to move it into FW.

@mjurc
Copy link
Member

mjurc commented Oct 8, 2024

Hey, let's just handle this in the job - this is a simple module exclusion, and we have scenarios where those tests are excluded already (like OSD testing). Can you check that?

@mocenas
Copy link
Contributor Author

mocenas commented Oct 8, 2024

OK I've created MR into jobs.

@mocenas mocenas closed this Oct 8, 2024
@mocenas mocenas deleted the disable_external_apps_on_aarch branch October 8, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants