Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures in CLI #2080

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix failures in CLI #2080

merged 1 commit into from
Oct 10, 2024

Conversation

fedinskiy
Copy link
Contributor

Summary

We have --stream parameter enabled everywhere by default, but this behavior conflicts with --platform option, we use in several tests

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

We have --stream parameter enabled everywhere by default,
but this behavior conflicts with --platform option, we use in several tests
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about failures, but I think the PR description makes sense.

If you specify the platform BOM without version, I'd expect this to work (like RHBQ I can migrate from 3.2 to 3.8 but still want to specify group id and artifact id). But in cases that are changed by this PR, version is always added and then, it doesn't make sense to require stream.

Quarkus CLI docs is silent on that so I'll approve:

Quarkus version:
  -S, --stream=platformKey:streamId
                             A target stream, for example:
                               io.quarkus.platform:2.0
  -P, --platform-bom=groupId:artifactId:version
                             A specific Quarkus platform BOM, for example:
                               io.quarkus.platform:quarkus-bom:2.2.0.Final
                               io.quarkus::999-SNAPSHOT  2.2.0.Final
                             Default groupId: io.quarkus.platform
                             Default artifactId: quarkus-bom

Please merge it if the CI is green.

@fedinskiy fedinskiy self-assigned this Oct 10, 2024
@fedinskiy fedinskiy merged commit ed4ec1e into quarkus-qe:main Oct 10, 2024
8 checks passed
@fedinskiy fedinskiy deleted the fix/cli branch October 10, 2024 11:35
@fedinskiy fedinskiy mentioned this pull request Oct 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants