Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Agroal from 2.3 to 2.4 #40779

Merged
merged 1 commit into from
May 23, 2024
Merged

Bump Agroal from 2.3 to 2.4 #40779

merged 1 commit into from
May 23, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented May 22, 2024

This fixes QUARKUS-4185:

"Every two minutes, the "periodic recovery" thread runs for each XA data source. It opens a connection to the database (Microsoft SQL Server), performs some queries, and then closes the connection.

Over time, the difference between "Start create new connection for pool" and "Closing physical connection" log entries shows that database connections are left open, which is confirmed on the SQL Server end in the dm_exec_connections table."

@quarkus-bot quarkus-bot bot added area/agroal area/dependencies Pull requests that update a dependency file labels May 22, 2024
@gastaldi gastaldi requested review from barreiro and gsmet May 22, 2024 14:18
@gastaldi gastaldi marked this pull request as ready for review May 23, 2024 11:54
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 23, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented May 23, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7fa51f0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gsmet gsmet merged commit d1b5cff into quarkusio:main May 23, 2024
65 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 23, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 23, 2024
@gastaldi gastaldi deleted the bump_agroal branch May 23, 2024 14:37
@gsmet gsmet modified the milestones: 3.12 - main, 3.11.1 Jun 4, 2024
yrodiere added a commit to yrodiere/quarkus that referenced this pull request Jun 10, 2024
Following quarkusio#40779 / agroal/agroal@6c62f82,
the exception message changed and is a bit more explicit.
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Jun 10, 2024
Following quarkusio#40779 / agroal/agroal@6c62f82,
the exception message changed and is a bit more explicit.

(cherry picked from commit 2d99f1d)
@gsmet gsmet modified the milestones: 3.11.1, 3.8.6 Jul 18, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Jul 31, 2024
Following quarkusio#40779 / agroal/agroal@6c62f82,
the exception message changed and is a bit more explicit.
danielsoro pushed a commit to danielsoro/quarkus that referenced this pull request Sep 20, 2024
Following quarkusio#40779 / agroal/agroal@6c62f82,
the exception message changed and is a bit more explicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agroal area/dependencies Pull requests that update a dependency file triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better exception when accessing two non-XA datasources in a transaction
3 participants