Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a disabled OidcClient REST client issue #40894

Merged
merged 1 commit into from
May 31, 2024

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented May 29, 2024

The earlier update which I thought was obviously fixing it was correct but incomplete (or may be I tried something with Resteasy Classic which made me believe it was complete, unfortunately I don't remember now).

So this PR fixes it properly and this fix is supported by the test.
The test adds a disabled OidcClient tenant, the flow is: test calls FrontentResource which uses RESTClient to call a secured ProtectedResource - which can only be accessed if OidcClient acquired the token. But because OidcClient is disabled, the request to ProtectedResource goes without the token (as opposed to be terminated with DisabledOidcClientException) and therefore 401 is returned from ProtectedResource and is passed further back to the test code to confirm

@quarkus-bot
Copy link

quarkus-bot bot commented May 29, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 02a1660.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 433856f into quarkusio:main May 31, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 31, 2024
@gsmet gsmet modified the milestones: 3.12 - main, 3.11.1 Jun 4, 2024
@gsmet gsmet modified the milestones: 3.11.1, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Unexpected DisabledOidcClientException
3 participants