Qute: fix possible stack overflow error in InsertSectionHelper #41517
Conversation
mkouba
commented
Jun 27, 2024
mkouba
commented
- fixes Qute: StackOverflowError due to nested #include and #insert directives #41451
|
@gbourant @ia3andy UPDATE: I think I found a way to mitigate the perf impact. I will update the PR tomorrow. |
|
@mkouba, I don't know if this is possible but at build time you might be able to give a random name to the insert directive and wrap the content of other templates to that named directive. (maybe it should be enabled via config?) For example the following templates:
<html>
<body>{#insert /}</body>
</html>
{#include auth.html}
<form>Login Form</form>
{/include}become:
<html>
<body>{#insert someRandomName /}</body>
</html>
{#include auth.html}
{#someRandomName}
<form>Login Form</form>
{/}
{/include} |
The problem is we have the same problem if those nested includes use the same explicit block name, i.e. |
|
I just tried it and it works buddy! :) |
What exactly? The fix in this PR? ;-) |
Yeah the fix in this PR. It doesn't throw OverflowError when using nested {#insert /} |
mkouba
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
@mkouba maybe we should backport this furtther? |
Yes, it's already labeled with |
|
@mkouba triage backport is just for 3.12, but we should backport it to as far as it's compatible no? |
