Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bytecode recording issue when default method is used as a getter #41609

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix bytecode recording issue when default method is used as a getter #41609

merged 1 commit into from
Jul 3, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 2, 2024 •
edited
Loading

@geoand geoand requested a review from mkouba July 2, 2024 11:55
@quarkus-bot quarkus-bot bot added the area/core label Jul 2, 2024
@geoand geoand changed the title Which bytecode recording issue when default method is used as a getter Fix bytecode recording issue when default method is used as a getter Jul 2, 2024
@geoand geoand force-pushed the default-method branch 2 times, most recently from f3c23f3 to 3a30f88 Compare July 2, 2024 12:05
metacosm
metacosm approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue in my testing. Thank you!

@geoand
Copy link
Contributor Author

geoand commented Jul 2, 2024

🙏🏼

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 2, 2024
@quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand merged commit 1c3455a into quarkusio:main Jul 3, 2024
52 checks passed
@geoand geoand deleted the default-method branch July 3, 2024 12:23
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 3, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 3, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.2 Jul 9, 2024
@gsmet gsmet modified the milestones: 3.12.2, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
3.8.6
Development

Successfully merging this pull request may close these issues.
4 participants
@geoand @metacosm @mkouba @gsmet