Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore config ServiceLoader files from Gradle sources #42650

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Ignore config ServiceLoader files from Gradle sources #42650

merged 1 commit into from
Aug 20, 2024

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Aug 20, 2024 •
edited
Loading

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Aug 20, 2024
@quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet reviewed Aug 20, 2024
View reviewed changes
.../gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/EffectiveConfig.java Outdated
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no star imports.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I updated my IDE recently, and the settings messed up. Fixed now.

gsmet
gsmet reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clever :).

Apart from the star import issue, this looks good to go.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 20, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 778834e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit ade77c2 into quarkusio:main Aug 20, 2024
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 20, 2024
@gsmet gsmet modified the milestones: 3.16 - main, 3.14.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bugfix triage/backport-3.13
Projects
None yet
Milestone
3.14.0
2 participants
@radcortez @gsmet