-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using bundles forbids normal rules embedding #355
Comments
quasilyte
added a commit
to quasilyte/go-perfguard
that referenced
this issue
Jan 10, 2022
See quasilyte/go-ruleguard#355 perfguard should not need that dependency when custom rules are not used. This is why we're using rules embedding.
This was referenced Jan 10, 2022
Maybe we can avoid custom decls generation for bundles? CustomDecls: []string{
"var Bundle = dsl.Bundle{}",
}, I'm not sure this part is 100% required for the generated data. |
quasilyte
added a commit
to quasilyte/go-perfguard
that referenced
this issue
Jan 10, 2022
See quasilyte/go-ruleguard#355 perfguard should not need that dependency when custom rules are not used. This is why we're using rules embedding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It'll require dsl package dependency at the run time.
The text was updated successfully, but these errors were encountered: