chore(quinn): feature flag socket2 imports #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jul 23, 2024
|
CI failures are due to #1936. |
The `socket2` imports are only used by the feature flagged `client` function.
Move the imports into the function to be feature flagged as well.
Avoids the following warning:
```
--> quinn/src/endpoint.rs:28:15
|
28 | use socket2::{Domain, Protocol, Socket, Type};
| ^^^^^^ ^^^^^^^^ ^^^^^^ ^^^^
|
= note: `#[warn(unused_imports)]` on by default
```
djc
approved these changes
Jul 25, 2024
|
Thanks! |
Ralith
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
socket2imports are only used by the feature flaggedclientfunction. Feature flag the imports as well.Avoids the following warning: