feat(acs): add support for acs data source #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-fs
reviewed
Oct 12, 2023
mirekdlugosz
previously requested changes
Oct 13, 2023
src/components/addCredentialType/__tests__/__snapshots__/addCredentialType.test.js.snap
Show resolved
Hide resolved
src/components/addSourceWizard/__tests__/__snapshots__/addSourceWizardStepOne.test.js.snap
Show resolved
Hide resolved
cdcabrera
reviewed
Oct 15, 2023
There was a problem hiding this comment.
@nicolearagao is there an intended update to API spec for ACS?
@cdcabrera yes, we will add ACS as a new source. |
Related to JIRA: DISCOVERY-350 https://issues.redhat.com/browse/DISCOVERY-350
nicolearagao
force-pushed
the
feature/support-acs-source
branch
from
0b00928
to
543f952
Compare
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 84.19% 84.19% -0.01%
==========================================
Files 116 116
Lines 3777 3783 +6
Branches 1341 1345 +4
==========================================
+ Hits 3180 3185 +5
- Misses 536 537 +1
Partials 61 61
Continue to review full report in Codecov by Sentry.
|
nicolearagao
requested review from
cdcabrera,
bruno-fs,
mirekdlugosz and
abellotti
cdcabrera
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
lgtm
- aligns to the similar update for ansible data source
$ yarn start:stage(shortcut for the above steps noted) and$ yarn startappear to function as intended- adding credentials
- adding sources
- adding scans
I'll defer to others in case I overlooked anything
nicolearagao
dismissed
mirekdlugosz’s stale review
mirek's PTO, changes that he requested were addressed.
bruno-fs
approved these changes
Oct 17, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Support for new ACS scanner
How to test
Ensure the workflow for adding/editing and deleting (when applicable) acs credential/source and a scanner is working as expected.
Local run check
$ yarn$ yarn build$ yarn run api:stageUpdates issue/story
https://issues.redhat.com/browse/DISCOVERY-350