Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ds-436 Add OCP default port in form logic #484

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

nicolearagao
Copy link
Member

Add conditional default port for OpenShift in form logic

Notes

  • fix to [mirek] improve port logic on sources:
    check for mirek comment
    default ports: 22 network / 6443 openshift / 443 rest

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm run start
  3. confirm connections display as intended

Example

Screenshot from 2024-10-14 10-55-10
Screenshot from 2024-10-14 10-55-03
Screenshot from 2024-10-14 10-54-55
Screenshot from 2024-10-14 10-54-40

Updates issue/story

DISCOVERY-436

@nicolearagao nicolearagao marked this pull request as ready for review October 14, 2024 13:58
@nicolearagao nicolearagao requested review from a team October 14, 2024 14:24
Copy link
Contributor

@mirekdlugosz mirekdlugosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright 👍

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically everything works, but lets alter the ternary for long term sanity

src/views/sources/addSourceModal.tsx Outdated Show resolved Hide resolved
@cdcabrera
Copy link
Member

Since Jenkins is acting up and the error seems off we're expanding the unit test to double check the new ternary

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work on the test update... minor change, and a question about the default port display...

src/views/sources/addSourceModal.tsx Show resolved Hide resolved
src/views/sources/addSourceModal.tsx Show resolved Hide resolved
@mirekdlugosz
Copy link
Contributor

Since Jenkins is acting up and the error seems off we're expanding the unit test to double check the new ternary

Jenkins sees that GitHub Actions check failed and bails out to save resources.

Here commit lint fails because it doesn't like commits starting with fixup!. I saw the same in few other PRs so there seems to be a disparity between what tool considers correct and what we actually do.

This relates to JIRA: DISCOVERY-436
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicolearagao nicolearagao merged commit c5c83b7 into main Oct 16, 2024
8 checks passed
@nicolearagao nicolearagao deleted the fix-ports-sources branch October 16, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants