Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ds-438 display items alphabetical order #486

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

nicolearagao
Copy link
Member

Display list of sources and credentials in alphabetical order

Notes

  • fix to [Mirek] A list of Sources used by a credential, or sources used by a scan (the one that appears in modal) is sorted by related items id. It would be more natural to sort it alphabetically.
    Not tested, but I assume the same applies to list of credentials used by a source

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm run start
  3. confirm connections display as intended

Example

Screenshot from 2024-10-15 21-38-32
Screenshot from 2024-10-15 21-38-25
Screenshot from 2024-10-15 21-38-16

Updates issue/story

DISCOVERY-438

@nicolearagao nicolearagao requested review from a team October 16, 2024 00:43
Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolearagao nicolearagao force-pushed the alphabetical-order-creds-sources branch from c21b483 to 87b7326 Compare October 17, 2024 01:26
@nicolearagao nicolearagao merged commit baf4808 into main Oct 17, 2024
7 checks passed
@nicolearagao nicolearagao deleted the alphabetical-order-creds-sources branch October 17, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants