Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aboutModal): ds-808 display user, status info #488

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 16, 2024

What's included

  • feat(aboutModal): ds-808 display user, status info
    • aboutModal, display user and status info
    • viewLayout, use title image helper
    • viewLayoutToolbar, add about modal open, close
    • helpers, add ui_version, getCurrentDate, getTitleImg
    • useStatusApi, use status api response

Notes

  • modifies the brand image into a centralized helper to avoid recreating the logic in multiple places
  • adds the centralized getCurrentDate and UI_VERSION helpers from v1.8
  • what this doesn't do (these items can be iterated on if necessary)
    • skips adding the UI browser type from v1.8 since it involves adding in one more NPM.
    • skips the v1.8 custom copy/paste behavior.
  • running locally
    • the randomized data local run using $ npm start (generated from the spec file) returns a 500 level error from the generated status call, unclear if there is something malformed in the spec since it complains about the shape of the response
    • there's a slight delay in the normal/staging run when the initial status api call is made. this may, or may not happen, in the standard run. to compensate we use a quick css transition to mask the load jump. if it becomes obvious we may need another solution to indicate loading for api_version and server_version
  • The use of Red Hat Inc in the copyright/trademark... is pulled from v1.8, confirmation may be needed on the use of Inc

How to test

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm run start:stage
  3. select the question mark circle next to the user name
    • confirm it displays the about modal similar to the example

Example

*note: the ui version 1.8.0 is currently the package.json version. this is local run behavior. the format for the ui version in production follows the format 0.0.0.XXXXXXX, a combination of the package.json version and git hash

Screenshot 2024-10-15 at 9 48 44 PM

Updates issue/story

DISCOVERY-808

@cdcabrera cdcabrera requested review from a team and nicolearagao October 16, 2024 01:15
@cdcabrera cdcabrera force-pushed the ds-808-aboutmodal branch 2 times, most recently from fe5e3c0 to 4d9461c Compare October 16, 2024 01:56
* aboutModal, display user and status info
* viewLayout, use title image helper
* viewLayoutToolbar, add about modal open, close
* helpers, add ui_version, getCurrentDate, getTitleImg
* useStatusApi, use status api response

Relates to JIRA: DISCOVERY-808
@cdcabrera cdcabrera merged commit 761344b into main Oct 16, 2024
7 checks passed
@cdcabrera cdcabrera deleted the ds-808-aboutmodal branch October 16, 2024 19:54
cdcabrera added a commit that referenced this pull request Oct 16, 2024
* aboutModal, display user and status info
* viewLayout, use title image helper
* viewLayoutToolbar, add about modal open, close
* helpers, add ui_version, getCurrentDate, getTitleImg
* useStatusApi, use status api response

Relates to JIRA: DISCOVERY-808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants