Core: Remove the newly introduced global hooks until we have consensus #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,6 +125,7 @@ Test.prototype = { | |||
| }; | |||
| }, | |||
|
|
|||
| // Currently only used for module-level hooks, can be used to add global level ones | |||
There was a problem hiding this comment.
only for consistency, we should keep or not the hyphen on "module-level" vs "global level".
IMHO, let's just change module-level to module level.
Between locating the hooks in `QUnit` or `QUnit.config` and making them simple setters and callback lists (like QUnit.done et al) and upcoming plans for nested suites, we decided not to release this feature, for now. I'm keeping the abstractions for hooks in place, so it should be trivial to bring this back in whatever form we decide on later. Effectively reverts 5ee31a0 and follow-up commits. Fixes qunitjs#665 Ref qunitjs#633 Ref qunitjs#635 Ref qunitjs#647
jzaefferer
force-pushed
the
remove-global-hooks
branch
from
e6262d9
to
acfd98c
Compare
|
Updated. I've now cut away the parts from the unit tests that were related to the new feature and kept the rest. |
|
LGTM |
|
FYI @stefanpenner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between locating the hooks in
QUnitorQUnit.configand making them simple setters and callback lists (like QUnit.done et al) and upcoming plans for nested suites, we decided not to release this feature, for now.I'm keeping the abstractions for hooks in place, so it should be trivial to bring this back in whatever form we decide on later.
Effectively reverts 5ee31a0 and follow-up commits.
Fixes #665
Ref #633
Ref #635
Ref #647