Skip to content

Commit

Permalink
Drop support for Python 3.8 (#107)
Browse files Browse the repository at this point in the history
  • Loading branch information
JelleZijlstra authored Oct 11, 2024
1 parent ab04891 commit da87a74
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 17 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
- uses: actions/setup-python@v4
name: Install Python
with:
python-version: "3.11"
python-version: "3.12"

- name: Install cibuildwheel
run: python -m pip install cibuildwheel==2.16.5
run: python -m pip install cibuildwheel==2.21.3

- name: Build wheels
run: python -m cibuildwheel --output-dir wheelhouse
Expand All @@ -40,10 +40,13 @@ jobs:
- uses: actions/setup-python@v4
name: Install Python
with:
python-version: "3.11"
python-version: "3.12"

- name: Install build
run: python -m pip install build==1.2.2.post1

- name: Build sdist
run: python setup.py sdist
run: python -m build --sdist

- uses: actions/upload-artifact@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8, 3.9, "3.10", "3.11", "3.12", "3.13"]
python-version: [3.9, "3.10", "3.11", "3.12", "3.13"]

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Unreleased

- Drop support for Python 3.8; declare support for Python 3.13

## 1.10.1

* Add minimum version requirement (Python 3.8) to metadata
Expand Down
9 changes: 4 additions & 5 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
[project]
name = "qcore"
version = "1.10.1"
requires-python = ">=3.8"
requires-python = ">=3.9"
keywords = ["quora", "core", "common", "utility"]
classifiers = [
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -20,7 +19,7 @@ license = {text = "Apache Software License"}
dynamic = ["readme"]

[tool.black]
target_version = ['py37', 'py38', 'py39', 'py310', 'py311']
target-version = ['py39', 'py310', 'py311', 'py312', 'py313']
include = '\.pyi?$'
skip-magic-trailing-comma = true
preview = true
Expand All @@ -36,7 +35,7 @@ exclude = '''
'''

[tool.mypy]
python_version = "3.7"
python_version = "3.9"
warn_unused_configs = true

[[tool.mypy.overrides]]
Expand All @@ -48,4 +47,4 @@ requires = ["setuptools>=64.0", "cython>=3"]
build-backend = "setuptools.build_meta"

[tool.cibuildwheel]
build = "cp{38,39,310,311,312}-*"
build = "cp{39,310,311,312,313}-*"
6 changes: 3 additions & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pytest==7.4.0
mypy==1.8.0
black==24.3.0
pytest==8.3.3
mypy==1.11.2
black==24.10.0
7 changes: 3 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tox]
minversion=2.3.1
envlist =
py38,py39,py310,py311,py312,py313
py39,py310,py311,py312,py313
mypy
black
skip_missing_interpreters = True
Expand All @@ -14,7 +14,7 @@ commands =
python -X dev -Werror -m pytest qcore

[testenv:mypy]
basepython = python3.8
basepython = python3.9
deps =
-rrequirements.txt

Expand All @@ -27,8 +27,7 @@ commands =

[gh-actions]
python =
3.8: py38, mypy
3.9: py39
3.9: py39, mypy
3.10: py310
3.11: py311
3.12: py312, black
Expand Down

0 comments on commit da87a74

Please sign in to comment.