use reordered dims properly for #680

r-spatial · Apr 24, 2024 · 367cc64 · 367cc64
1 parent d291c13
commit 367cc64
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/R/ncdf.R b/R/ncdf.R
@@ -183,7 +183,7 @@ read_ncdf = function(.x, ..., var = NULL, ncsub = NULL, curvilinear = character(
 
  # Create stars dimensions object
 
- if(is.null(nc_dim <- dim(out_data[[1]]))) nc_dim <- dims$length
+ nc_dim <- dims$count
 
  dimensions <- create_dimensions(setNames(nc_dim, dims$name),
  raster)

diff --git a/tests/testthat/test-ncdf.R b/tests/testthat/test-ncdf.R
@@ -313,9 +313,17 @@ test_that("axis attribute order -- see #680", {
 
  s2 <- suppressWarnings(stars::read_ncdf(file2))
 
- expect_equal(names(stars::st_dimensions(s2)), c("lon", "lat", "time"))
+ d <- stars::st_dimensions(s2)
+
+ expect_equal(names(d), c("lon", "lat", "time"))
 
+ expect_equal(d$time$to, 9)
+
  s3 <- suppressWarnings(stars::read_ncdf(file3))
 
- expect_equal(names(stars::st_dimensions(s3)), c("lon", "lat", "time"))
+ d <- stars::st_dimensions(s2)
+
+ expect_equal(names(d), c("lon", "lat", "time"))
+
+ expect_equal(d$time$to, 9)
 })