Handle WebAssembly.RuntimeError by closing communication channel
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Going to test this in r-universe right away. |
|
Hopefully the OOM failure behaviour is more reasonable now! BTW you might need to wait a little while for CI to catch up, it rebuilds absolutely everything from scratch and takes a while before uploading the new Wasm binaries to AWS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes:
If
WebAssembly.RuntimeErroris raised and bubbles all the way up to the top level, catch it and report the problem as unrecoverable onconsole.error(). Then close the communication channel, terminating the worker thread.If a communication channel has been closed, reject any promises trying to write on the channel with a
WebRChannelError.Closes #464, because the OOM error is a
WebAssembly.RuntimeError.