Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml instead of setup.py for packaging #147

Closed
gahjelle opened this issue Nov 18, 2022 · 3 comments · Fixed by #151
Closed

Move to pyproject.toml instead of setup.py for packaging #147

gahjelle opened this issue Nov 18, 2022 · 3 comments · Fixed by #151

Comments

@gahjelle
Copy link

gahjelle commented Nov 18, 2022

When installing parse with a recent version of Pip, I get the following warning:

DEPRECATION: parse is being installed using the legacy 'setup.py install' method, because it
does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce
this behaviour change. A possible replacement is to enable the '--use-pep517' option.
Discussion can be found at https:/pypa/pip/issues/8559

@r1chardj0n3s Would you be interested in a PR moving to a "modern" build system? I can also update the tests and classifiers so that they run on the currently supported Python versions: 3.7 to 3.11

@rnickle
Copy link

rnickle commented Mar 3, 2023

Running into a 517 issue with pip 23.0.1, poetry 1.2.2 and python 3.10:

Note: This error originates from the build backend, and is likely not a problem with poetry but with parse (1.19.0) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "parse (==1.19.0)"'.

On the other hand, I seem to have no trouble at all building parse as suggested:

pip wheel --use-pep517 "parse (==1.19.0)" --no-cache-dir

@wimglenn
Copy link
Collaborator

This is also because it's installing from sdist (no wheel on PyPI).
Related: #144

@wildone
Copy link

wildone commented May 31, 2023

Addin

Running into a 517 issue with pip 23.0.1, poetry 1.2.2 and python 3.10:

Note: This error originates from the build backend, and is likely not a problem with poetry but with parse (1.19.0) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "parse (==1.19.0)"'.

On the other hand, I seem to have no trouble at all building parse as suggested:

pip wheel --use-pep517 "parse (==1.19.0)" --no-cache-dir

Adding --use-pep517 "parse (==1.19.0)" to my pip install command worked! Thank you. I am on Python 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants