Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve receive message error handling #158

Open
portante opened this issue Apr 27, 2023 · 0 comments
Open

Improve receive message error handling #158

portante opened this issue Apr 27, 2023 · 0 comments

Comments

@portante
Copy link

See also #97 and chmouel/gosmee#77.

If a very large payload is published, one that is bigger than the 65K default buffer size, the client silently re-subscribes without any indication of an error.

Adding some kind of OnError() event handling describing the failure mode would have saved days of debugging (yes, strace is your friend).

portante added a commit to portante/gosmee that referenced this issue Apr 27, 2023
See r3labs/sse#158, "Improve receive message
error handling."

Fixes chmouel#77, "`ERROR gosmee
bufio.Scanner: token too long`".
portante added a commit to portante/gosmee that referenced this issue Apr 27, 2023
See r3labs/sse#158, "Improve receive message
error handling."

Fixes chmouel#77, "`ERROR gosmee
bufio.Scanner: token too long`".
portante added a commit to portante/gosmee that referenced this issue Apr 27, 2023
See r3labs/sse#158, "Improve receive message
error handling."

Fixes chmouel#77, "`ERROR gosmee
bufio.Scanner: token too long`".
portante added a commit to portante/gosmee that referenced this issue Apr 29, 2023
See r3labs/sse#158, "Improve receive message
error handling."

Fixes chmouel#77, "`ERROR gosmee
bufio.Scanner: token too long`".
chmouel pushed a commit to chmouel/gosmee that referenced this issue May 2, 2023
See r3labs/sse#158, "Improve receive message
error handling."

Fixes #77, "`ERROR gosmee
bufio.Scanner: token too long`".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant