Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Making "rabbitmq-service.bat start" section optional (controlled by switch during silent install) #105

Open
inikulshin opened this issue Jun 24, 2019 · 2 comments
Assignees

Comments

@inikulshin
Copy link

inikulshin commented Jun 24, 2019

Firstly, choosing whether to run the just installed application or not is a very common and basic installer option. Almost every installer gives this choice to user.

Secondly, we have a real issue with it: we have custom exchanges plugins in plugins, so when we upgrade RabbitMQ, we loose them. So, after the installation we must only hope messages are not lost (because plugins are unavailable) until we stop RabbitMQ service (and stopping RabbitMQ service just after the start is not trivial at all - it may cause a corruption if RabbitMQ service is not completely started), copy our plugins to plugins and start RabbitMQ service again.

Can this code from windows-exe/rabbitmq_nsi.in be put in a separate command line controlled optional [sub]section?

  DetailPrint "Starting RabbitMQ service..."
  ExecDos::exec /DETAILED '"$INSTDIR\rabbitmq_server-%%VERSION%%\sbin\rabbitmq-service.bat" start' ""

[168224478]

@inikulshin
Copy link
Author

Also, all manipulations with .erlang.cookie should be done before staring RabbitMQ service.

@lukebakken
Copy link
Contributor

If you have time to submit a pull request implementing this feature, that would be the fastest way to get it added to RabbitMQ. The NSIS documentation is available here

@lukebakken lukebakken self-assigned this Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants