Replace syntex with rustc-ap-syntax #854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
syntex_syntax
is no longer maintained, so we have to move towardslibsyntax
.Here I list up change from our current
syntex_syntax 52.0
andrustc-ap-syntax 133.0
(though not all).visit::Visitor
needs life time(now its declaration ispub trait Visitor<'ast>: Sized
)use
is completely differentExprKind::TupField
is removed by Hygiene 2.0: Avoid comparing fields by name rust-lang/rust#49718By this change, we become unable to compile racer with
beta
orstable
compiler.So we have to decide some things.
rustfmt-nightly
?syntex
branch?I constructed this PR from kngwyu#1 kngwyu#2 kngwyu@40466f6 and some commits.