update security group naming schema #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding Issue(s) or trello card(s):
fixes https:/rackspace-infrastructure-automation/aws-terraform-internal/issues/211
Summary of change(s):
Changes the security group to be like the other security group naming structure.
Because of issues with destroying a recreated security group resource dependency we had to add a create before destroy to make this work properly.
See issue: hashicorp/terraform-provider-aws#1671
See failed CI run for this update without create_before_destroy https://circleci.com/gh/rackspace-infrastructure-automation/aws-terraform-efs/53
Will the change trigger resource destruction or replacement? If yes, please provide justification:
yes, it will because of name structure changes. This makes it more in-line with other security group naming schemas
Does this update/change involve issues with other external modules? If so, please describe the scenario.
no
If input variables or output variables have changed or has been added, have you updated the README?
none
Do examples need to be updated based on changes?
no
Note to the PR requester about Closing PR's
Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.
This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.