fix(git_changelog_generate): pass tag if it exists to gitReadLog #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a tag was found the script would try to find commits between undefined..HEAD. By passing the tag, it now finds tags between tag..HEAD. Closes rafinskipg#5.
|
You are cool, thanks for contributing. I will take more care of the git changelog thanks to you |
rafinskipg
pushed a commit
that referenced
this pull request
Jan 28, 2014
fix(git_changelog_generate): pass tag if it exists to gitReadLog
|
I need to make some changes for myself but I'll see if you want them!
|
|
Yeah! All the fixs are welcome, if you release some big changes we can publish a new version to npm, In fact I will publish a new minor version with your changes this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a tag was found the script would try to find commits
between undefined..HEAD. By passing the tag, it now finds tags between
tag..HEAD.
Closes #5.