-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
payola_spy gem reporting incorrect compatibility data #88
Comments
Where is that happening? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there,
This might have been me testing the new GitHub Actions setup. See #84
When I ran the GitHub Action for this gem (https://www.railsbump.org/gems/payola_spy) I saw this:
The logic to check compatibility removes the Rails dependency to avoid declaring one dependency twice in the
Gemfile
So now it is showing that the gem is compatible with Rails 5.2 and higher, which I think is inaccurate.
Expected
I would expect the compatibility to show:
I think we need to honor the declared dependencies before trying to check with the GitHub Action.
@manuelmeurer Is this something that is already considered in the order of the strategies that are attempted? Maybe I missed something
Thanks!
The text was updated successfully, but these errors were encountered: