Add tracing logging #887
Closed
Add tracing logging #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I agree with this PR change. I can see using a tracing library for warnings and errors. But for main logging it really changes what the output looks like Now
Previous
IMO the reasons for switching (Rust uses it and other services can parse build logs) are not strong enough for us to switch since it decreases the quality of logs for users using Nixpacks on Railway or with the CLI. |
|
Going to close this for the reasons listed above. I'm happy to move to a better more standardized logging system. But the quality of logs needs to go up, not down. The most important logs is the build plan at the top which shows how the app will be built. |
|
@coffee-cup sorry I am not check the normal log. 🤔️ I got your means. Let me think how to do better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tried to add a logging library for better user and developer experience.
Only transformed all our
println!with logging library.Why tracing?
Rust compiler using it (rust-lang/rust#74726).
It gives us structured logging power, then we(also other service using nixpacks) can easily collecting and parse building logs. (expecially error logs)