Feat/flat error events #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tags to generated resources indicating their source Kubernetes resource. (WIP: Ingress v1 only for now) When OnUpdateInMemoryMode receives a configuration rejected error from the /config endpoint, parse the new tagged flat error array into a list of errors associated with their source Kubernetes resource. Generate a Kubernetes Event for all configuration rejection errors associated with the source Kubernetes resource.
Add a utility function to generate Kubernetes resource metadata Kong tags from a client.Object. Use the utility to add tags to resources generated by the parser.
Also update go-kong to 0.36.
Track the parent xRoute/Ingress/etc. when populating services. For cases where there is no proper Kubernetes Service to indicate as the cause of a problem (multi-Service backends and default backends), add tags indicating the parent route as the source of the Kong resource. Handle a newly-discovered edge case in service generation that would break service tag addition with a TODO. The bug predates this change, but was apparently benign until this change.
These aren't even my changes golangci-lint! Begone!
1 task
Codecov ReportBase: 73.7% // Head: 72.6% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
- Coverage 73.7% 72.6% -1.2%
=======================================
Files 111 122 +11
Lines 13285 14581 +1296
=======================================
+ Hits 9803 10587 +784
- Misses 2852 3318 +466
- Partials 630 676 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Unite the if clauses for the expected special Service tag handling (GWAPI multi-service backend) and unexpected bug Service (no backend) tag handling, to avoid one overwriting the other.
rainest
force-pushed
the
feat/flat-error-events
branch
from
bf4c1e9
to
dd88418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR to run against unreleased Kong in CI