Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_bed.py chokes on find_circ2 output #9

Open
mschilli87 opened this issue Feb 7, 2017 · 4 comments
Open

merge_bed.py chokes on find_circ2 output #9

mschilli87 opened this issue Feb 7, 2017 · 4 comments

Comments

@mschilli87
Copy link
Member

Trying to combine two runs analyzed with the latest find_circ2 by

merge_bed.py \
  --format=2 \
  <(zcat sample1.circ_splice_sites.bed.gz) \
  <(zcat sample2.circ_splice_sites.bed.gz) \
| pigz \
  --best \
> merged.circ_splice_sites.bed.gz

I get

circ_splice_sites
Traceback (most recent call last):
  File "merge_bed.py", line 176, in <module>
    cols = [comstr] + consensus_cols(lines,comb)
  File "merge_bed.py", line 138, in consensus_cols
    parts.append(str(col_map[i](column)))
  File "merge_bed.py", line 123, in <lambda>
    9 : lambda values : array(values,dtype=int).sum(), # sum ov_linear_A
ValueError: invalid literal for long() with base 10: '0.5'

@marvin-jens: I'm willing to fix it myself but I'll need some directions. ;)

@mschilli87 mschilli87 changed the title merge_bed.py chokes on find_circ2 output merge_bed.py chokes on find_circ2 output Feb 7, 2017
@mschilli87
Copy link
Member Author

@retaj: Maybe you can comment how you do these kind of things? ciRcus/BED6 only/Not at all?

@marvin-jens
Copy link
Member

Hi Marcel, didn't see the notification as MDC email is checked only intermittently. I'd prefer if you guys would move this functionality to ciRcus. Table merging is definitely sth that's handled more cleanly in R. The merge_bed.py is a bit hacky, to say the least, and I wouldn't be sad to see it go away. Thanks for inquiring.

@mschilli87
Copy link
Member Author

mschilli87 commented Feb 15, 2017

Allright, marked as [wontfix].

Reading find_circ2 output is supported in ciRcus since about a week (BIMSBbioinfo/ciRcus@c8ef7f5).

I'll leave this issue open until we have

  • implemented proper flag merging in ciRcus,
  • updated the find_circ2 README accordingly &
  • deleted merge_bed.py from this repository.

PS: It is possible to update your email on github. ;)
PPS: Make sure to keep the old one (as non-primary) to not loose association of old commits to you profile.

@marvin-jens
Copy link
Member

marvin-jens commented Feb 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants