Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 Error for Holders #1908

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

vittoboa
Copy link
Contributor

Fix for the issue #1904, the ticker symbol has been moved from the parameters to the end of the base URL.

@sshcli
Copy link

sshcli commented Apr 16, 2024

Thanks @vittoboa for the fix

@ValueRaider we need your superpowers, please help us with the review and merge for this PR, and the release of 0.2.38.

Thanks in advance

Mates that will be grateful with you:
@EthanW33
@farbodbahari
@melgazar9
@hectoorperezz
@vittoboa
@sshcli

@ValueRaider
Copy link
Collaborator

ValueRaider commented Apr 16, 2024

This can merge straight into main branch

Exception: urgent bug-fixes can go straight into main, because presumably main is broken anyway. #1084

(I'll rephrase this)

Also dev has some other changes I don't want to force on users.

Rebase instructions in #1084

@vittoboa vittoboa changed the base branch from dev to main April 16, 2024 20:35
@vittoboa
Copy link
Contributor Author

Rebased 👍

@ValueRaider ValueRaider merged commit 18089f4 into ranaroussi:main Apr 16, 2024
1 check passed
@sshcli
Copy link

sshcli commented Apr 16, 2024

Just Perfect!
Many thanks @ValueRaider @vittoboa

@ValueRaider ValueRaider mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants