Skip to content

Commit

Permalink
updating documentation, DESCRIPTION, etc
Browse files Browse the repository at this point in the history
  • Loading branch information
randomchars42 committed Nov 13, 2018
1 parent 739767c commit 76b14ae
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 2,579 deletions.
3 changes: 3 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
^CRAN-RELEASE$
^Meta$
^doc$
^.*\.Rproj$
^\.Rproj\.user$
^README\.Rmd$
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
Meta
doc
.Rproj.user
.Rhistory
.RData
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: bioset
Type: Package
Title: Convert a Matrix of Raw Values into Nice and Tidy Data
Version: 0.2.2
Version: 0.2.3
Authors@R: person("Eike Christian", "Kühn",
email = "[email protected]",
role = c("aut", "cre"))
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# bioset 0.2.3

* `set_read`: check `additional_vars` for column names that might get overwritten
* `canonicalise_units`: fix unit conversion for % w / v (will throw warning)

# bioset 0.2.2

* adapt code to changes coming dplyr 0.7.5 (thanks to krlmlr)
Expand Down
10 changes: 6 additions & 4 deletions R/set.R
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,12 @@ set_read <- function(
is.character(additional_sep)
)

# check additional_vars for column names that will get overwritten
for (i in 1 : length(additional_vars)) {
if (additional_vars[[i]] %in% c("name", "real", "recovery", "conc", "value")) {
warning("\"", paste0(additional_vars[[i]], "\" may not be used as column name"))
if (length(additional_vars) > 0) {
# check additional_vars for column names that will get overwritten
for (i in 1 : length(additional_vars)) {
if (additional_vars[[i]] %in% c("name", "real", "recovery", "conc", "value")) {
warning("\"", paste0(additional_vars[[i]], "\" may not be used as column name"))
}
}
}

Expand Down
6 changes: 3 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
## Test environments

* local ubuntu 17.04 install, R 3.4.2
* r-hub x86_64-pc-linux-gnu 64-bit (devel: 2018-04-14 r74601)
* win-builder (devel: 2018-04-16 r74611)
* local ubuntu 17.04 install, R 3.5.1
* r-hub x86_64-pc-linux-gnu 64-bit, R devel: 2018-11-10 r75583
* win-builder, R 3.5.1

## R CMD check results

Expand Down
175 changes: 0 additions & 175 deletions vignettes/introduction.R

This file was deleted.

Loading

0 comments on commit 76b14ae

Please sign in to comment.