Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] model save problem in cuml #6069

Open
skyqwe123 opened this issue Sep 16, 2024 · 1 comment
Open

[BUG] model save problem in cuml #6069

skyqwe123 opened this issue Sep 16, 2024 · 1 comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@skyqwe123
Copy link

skyqwe123 commented Sep 16, 2024

@msarahan @seberg @benfred @mattf Thanks for your good job! When i use cuml, the model can not be saved like sklearn.

Describe the bug
Models cannot be saved like sklearn.

if we use sklearn, it works:
import torch
from sklearn import random_projection
model = random_projection.SparseRandomProjection(eps=0.1)
torch.save(model, 'model.pkl')

in cuml it not work and give following error:
import cuml
model = cuml.random_projection.SparseRandomProjection(eps=0.1)
torch.save(model, 'model.pkl')

TypeError: self.rand_matD,self.rand_matS cannot be converted to a Python object for pickling

@skyqwe123 skyqwe123 added ? - Needs Triage Need team to review and classify bug Something isn't working labels Sep 16, 2024
@dantegd
Copy link
Member

dantegd commented Sep 23, 2024

Thanks for the issue @skyqwe123, I haven't used torch.save before with sklearn estimators, seems like it relies in pickle so this must be exposing a bug in our pickling of Spars Random Projection, so this is something we will work in but don't have an ETA currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants