Use raft current_resource wrappers #6059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n using rmm::device_buffer.
harrism
changed the title
harrism
added
feature request
harrism
commented
Sep 4, 2024
| @@ -38,7 +38,10 @@ namespace genetic { | |||
| class GeneticProgramTest : public ::testing::Test { | |||
| public: | |||
| GeneticProgramTest() | |||
| : d_data(0, cudaStream_t(0)), | |||
| : nodes1_buffer(7 * sizeof(node), stream), | |||
There was a problem hiding this comment.
By constructing device_buffer in the constructor of the fixture, we can eliminate the raw allocation and deallocation in SetUp and TearDown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6058
Also eliminates some raw allocation using
rmm::device_buffer.Depends on rapidsai/raft#2424