Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pytest failures on warnings from cudf (Ensure values being set are casted to the object's type) #1358

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

mroeschke
Copy link
Contributor

Description

In 24.04, cudf issues a FutureWarning when setting a value to a column would change the data type of the original column. The fix involves casting the original column to the value's type first or vice versa. Could use a second eye on the correct direction to cast if a data type was used intentionally.

Additionally the test suite will now fail when a warning comes from cudf as apart of rapidsai/build-planning#26

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner March 7, 2024 01:21
@github-actions github-actions bot added the Python Related to Python code label Mar 7, 2024
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the type casts happens in binary predicates. Can @thomcom take a look?

@harrism
Copy link
Member

harrism commented Mar 11, 2024

I am not an expert on Python casts so please get another review before merging. Also, the title of the issue should probably include something about the casting, since the change to enable warnings as failures is a small part of the PR.

@mroeschke mroeschke changed the title Enable pytest failures on warnings from cudf Enable pytest failures on warnings from cudf (Ensure values being set are casted to the object's type) Mar 11, 2024
@thomcom
Copy link
Contributor

thomcom commented Mar 12, 2024

Thanks for your quick updates @isVoid looks good to me.

@thomcom thomcom self-requested a review March 12, 2024 14:29
@isVoid isVoid added tech debt Related to improving software quality non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 12, 2024
@isVoid
Copy link
Contributor

isVoid commented Mar 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 6298419 into rapidsai:branch-24.04 Mar 12, 2024
71 checks passed
@mroeschke mroeschke deleted the testing/cudf/warnings branch March 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code tech debt Related to improving software quality
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants