Replace rmm::mr::device_memory_resource* with rmm::device_async_resource_ref #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
improvement
trxcllnt
approved these changes
Apr 17, 2024
isVoid
approved these changes
Apr 18, 2024
isVoid
reviewed
Apr 18, 2024
| that enables consumers to specify properties of resources that they expect. These are defined | ||
| in the `cuda::mr` namespace of libcu++, but RMM provides some convenience wrappers in | ||
| `rmm/resource_ref.hpp`: | ||
| - `rmm::device_async_resource_ref` accepts a memory resource that provides synchronous allocation |
There was a problem hiding this comment.
Do you mean device_resource_ref here? It looks like a duplicate of below.
There was a problem hiding this comment.
Yes typo. Made same error in libcudf.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1371
Replaces all occurrences of
rmm::mr::device_memory_resource*in parameters withrmm::device_async_resource_ref. Also updates guidance in the DEVELOPER_GUIDE.mdChecklist