-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace device_memory_resource* with device_async_resource_ref #2261
Closed
Labels
improvement
Improvement / enhancement to an existing function
Comments
rapids-bot bot
pushed a commit
that referenced
this issue
Apr 24, 2024
Closes #2261 For reviewers: Many of changes are simple textual replace of `rmm::mr::device_memory_resource *` with `rmm::device_async_resource_ref`. However there are several places where RAFT used a default value of `nullptr` for `device_memory_resource*` parameters. This is incompatible with a `resource_ref`, which is a lightweight non-owning reference class, not a pointer. In most places, I was able to either remove the default parameter value, or use `rmm::mr::get_current_device_resource()`. In the case of ivf_pq, I removed the deprecated versions of `search` that took an `mr` parameter. I removed the unused old src/util/memory_pool.cpp and its headers. Authors: - Mark Harris (https:/harrism) Approvers: - Artem M. Chirkin (https:/achirkin) - Dante Gama Dessavre (https:/dantegd) - Corey J. Nolet (https:/cjnolet) URL: #2269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Update occurences of
rmm::mr::device_memory_resource*
tormm::device_async_resource_ref
in this repo. The rationale is explainedin this document.
The text was updated successfully, but these errors were encountered: