Update aerospace extension #14886
Update aerospace extension #14886
Conversation
- Adds functionality to change apps in current workspace - Initial commit
raycastbot
added
extension fix / improvement
|
Thank you for your contribution! 🎉 🔔 @limonkufu @AmmarCodes you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days. |
There was a problem hiding this comment.
Not sure why this file was included in the commit, I think it should be removed.
There was a problem hiding this comment.
In Raycast extension guidelines: “ Please use npm for installing dependencies and include package-lock.json in your pull request.”
There was a problem hiding this comment.
I should have included it myself, thanks
Co-authored-by: Ammar Alakkad <[email protected]>
Co-authored-by: Ammar Alakkad <[email protected]>
|
I understand. My point is about this PR not adding any dependencies yet
updating the lock file. We can leave this for the maintainer if you prefer.
…On Sat, Oct 12, 2024 at 12:15 Alejandro Cámara ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On extensions/aerospace/package-lock.json
<#14886 (comment)>:
In Raycast extension guidelines: “ Please use npm for installing
dependencies and include package-lock.json in your pull request.”
—
Reply to this email directly, view it on GitHub
<#14886 (comment)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AACVYGHCI3OWA6GZ2DH2LBLZ3DSB3AVCNFSM6AAAAABPZL7WCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRTHAZTONJYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Honestly, I’m not knowledgeable enough. So whatever is the best thing to do.
Alejandro Cámara López
Interaction Designer
alejandrocamara.info
On Sat, 12 Oct 2024 at 11:19, Ammar Alakkad ***@***.***>
wrote:
… I understand. My point is about this PR not adding any dependencies yet
updating the lock file. We can leave this for the maintainer if you
prefer.
On Sat, Oct 12, 2024 at 12:15 Alejandro Cámara ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> On extensions/aerospace/package-lock.json
> <#14886 (comment)>:
>
> In Raycast extension guidelines: “ Please use npm for installing
> dependencies and include package-lock.json in your pull request.”
>
> —
> Reply to this email directly, view it on GitHub
> <#14886 (comment)>,
> or unsubscribe
> <
https:/notifications/unsubscribe-auth/AACVYGHCI3OWA6GZ2DH2LBLZ3DSB3AVCNFSM6AAAAABPZL7WCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRTHAZTONJYHA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#14886 (comment)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AAA5U36NOTAIDRSV7CF4N7DZ3DSSTAVCNFSM6AAAAABPZL7WCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGQ3TEMJSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| # - https://nikitabobko.github.io/AeroSpace/commands#list-windows | ||
| # - https://www.alfredapp.com/help/workflows/inputs/script-filter/json/ | ||
|
|
||
| result=$(aerospace list-windows --workspace visible --format "%{app-name},%{window-title},%{window-id},%{app-pid},%{workspace},%{app-bundle-id}") |
There was a problem hiding this comment.
I don't have control over this PR, and the final say is after people who support the raycast plugin.
But as a maintainer of AeroSpace, the hacking around unstructured format makes me sad. Sure, you can use it for your own needs, but when you publish it for other people, I think it's better to clean it up. I'd wait for nikitabobko/AeroSpace#577 before merging this PR
I want to take this opportunity to remind that the plugin currently parses aerospace.toml config itself (which is fragile), while the proper API was provided nikitabobko/AeroSpace#215 (comment) (and still waits to be used)
This PR increases the technical debt of the raycast plugin
There was a problem hiding this comment.
List-windows.sh shouldn’t have been added. The command uses array-windows.sh but your comment still applies.
I don’t mind waiting if it will improve the code and technical debt. I started the PR before seeing the —json improvement.
|
Hey @nikitabobko,
I was afraid you would comment and remind me that I still been to change
that logic.
Family and other things happened so I couldn't do it. I am planning to do
it soon though hopefully in two weeks 😬
I am glad for you to give me a proper way and apologise again for my
tardiness
…On Sat, 12 Oct 2024, 12:43 Nikita Bobko, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In extensions/aerospace/assets/scripts/list-windows.sh
<#14886 (comment)>:
> @@ -0,0 +1,15 @@
+#!/usr/bin/env bash
+
+# References:
+# - https://nikitabobko.github.io/AeroSpace/commands#list-windows
+# - https://www.alfredapp.com/help/workflows/inputs/script-filter/json/
+
+result=$(aerospace list-windows --workspace visible --format "%{app-name},%{window-title},%{window-id},%{app-pid},%{workspace},%{app-bundle-id}")
I don't have control over this PR, and the final say is after people who
support the raycast plugin.
But as a maintainer of AeroSpace, the hacking around unstructured format
makes me sad. Sure, you can use it for your own needs, but when you publish
it for other people, I think it's better to clean it up. I'd wait for
nikitabobko/AeroSpace#577
<nikitabobko/AeroSpace#577> before merging this
PR
I want to take this opportunity to remind that the plugin currently parses
aerospace.toml config itself (which is fragile), while the proper API was
provided nikitabobko/AeroSpace#215 (comment)
<nikitabobko/AeroSpace#215 (comment)>
(and still waits to be used)
This PR increases the technical debt of the raycast plugin
—
Reply to this email directly, view it on GitHub
<#14886 (review)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AB2LFHD6WC2FZMWJ5NKYZX3Z3EDOXAVCNFSM6AAAAABPZL7WCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRTHA4TONBYGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Closed in favor of updated version with Aerospace 0.15.0. |
|
So is this switchApps functionality coming soon then? I was just working on adding it myself - would be great if it's already in the works! |
Yes, there is already a new PR with this functionality and aerospace latest —json improvement. Feel free to look at it and add any improvements (I’m not a developer so any fix, improvement or suggestion is welcome) |
Description
Adds a new command to change apps of the current workspace.
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder