Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update word-search extension #14923

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Update word-search extension #14923

merged 3 commits into from
Oct 17, 2024

Conversation

j3lte
Copy link
Contributor

@j3lte j3lte commented Oct 14, 2024

Description

Screencast

Checklist

- Update
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: word-search Issues related to the word-search extension OP is contributor The OP of the PR is a contributor of the extension labels Oct 14, 2024
@raycastbot
Copy link
Collaborator

raycastbot commented Oct 14, 2024

Thank you for your contribution! 🎉

🔔 @RishabSwift @thomaspaulmann @bkeys818 you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@RishabSwift
Copy link
Contributor

Can we have it so that the details view is not enabled by default? I think the toggle is a good option in preferences but seeing all definitions at once might be better

@j3lte
Copy link
Contributor Author

j3lte commented Oct 15, 2024

@RishabSwift by default it is off

@pernielsentikaer
Copy link
Collaborator

Another approach could be using useCachedState to remember if it's open or not. This way, it wouldn't require a new setting. Would that be a good idea?

@pernielsentikaer pernielsentikaer self-assigned this Oct 16, 2024
@j3lte
Copy link
Contributor Author

j3lte commented Oct 16, 2024

@pernielsentikaer agreed, I'll update the PR

@j3lte
Copy link
Contributor Author

j3lte commented Oct 16, 2024

@RishabSwift @pernielsentikaer I updated the code. Removed the introduced setting and instead just cache the 'Show Details' state

@pernielsentikaer
Copy link
Collaborator

Awesome 👏 That feels like a better solution - do you agree @RishabSwift

@RishabSwift
Copy link
Contributor

That’s awesome, I like this solution!

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit d86a8e5 into raycast:main Oct 17, 2024
2 checks passed
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/rishabswift/word-search

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: word-search Issues related to the word-search extension OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants