K8S-381 Connect all LXC services (UI/ETS/etc) to RPC-O MaaS #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs testing |
xgerman
force-pushed
the
mgd_k8s_lxc
branch
5 times, most recently
from
60ab64b
to
6e4c124
Compare
xgerman
force-pushed
the
mgd_k8s_lxc
branch
4 times, most recently
from
9b5c79a
to
0ddc3f9
Compare
|
@xgerman Sorry to be nit-picky, but can you move these lines to right above |
|
Needs a rebase.
Needs to be put in the first line of all the ticket. |
CrashenX
reviewed
May 17, 2018
| --- | ||
| features: | ||
| - | | ||
| Managed Kubernetes instals several laxc-conatiners for various |
There was a problem hiding this comment.
I didn't actually review this, I was just scrolling through quickly and my eyes caught this typo: s/instals/installs
There was a problem hiding this comment.
Also, is laxc a thing, or is it lxc?
|
recheck CIT/xenial_pike_deploy |
|
@xgerman: Overall looks good. Just need rebase and gates. Sorry, rebase one more time is needed. |
Adds process checks and (local) api checks. Note: Since most of the services except ui should not be widely exposed I am not adding checks for reaching them from the Interweb.
tonytan4ever
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds process checks and (local) api checks.
Note: Since most of the services except ui should not be widely exposed
I am not adding checks for reaching them from the Interweb.