Fix asm and global_asm macros #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for your contribution! |
simonschoening
force-pushed
the
master
branch
from
cbdc280
to
615df66
Compare
Thanks for your answer! I replaced it with the asm macro, but I'm not sure whether the implementation is correct. |
simonschoening
commented
Feb 25, 2022
Comment on lines
+16
to
+19
| asm!( | ||
| "mtc0 {trap_entry}, $15, 1", | ||
| trap_entry = in(reg) trap_entry, | ||
| ); |
There was a problem hiding this comment.
Is this correct?
There was a problem hiding this comment.
It seems right to me, but I'm not 100% sure. The MIPS target is least used, so maybe we can revisit it in the future.
The macros are now namespaced: rust-lang/rust#84019 In addition, llvm_asm was removed.
simonschoening
force-pushed
the
master
branch
from
615df66
to
98e384b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macros are now namespaced:
rust-lang/rust#84019