Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy storage #133

Closed
2 of 4 tasks
krizzu opened this issue Jun 18, 2019 · 3 comments
Closed
2 of 4 tasks

Legacy storage #133

krizzu opened this issue Jun 18, 2019 · 3 comments

Comments

@krizzu
Copy link
Member

krizzu commented Jun 18, 2019

This task involves reusing existing AsyncStorage implementation with the new API. New API available here.

To do:

  • Initial implementation of Legacy storage (thanks to @jeremyscatigna)

  • Setup an example to use said storage

  • Storage creation options (while instantiating):

  • Add flags as storage options:

    • Flag to tell if multi* operation should fail whole operation or just one and continue with the rest (reference here)

References:

This issue will be updated with any upcoming ideas/suggestions.

Blocked

#131

@krizzu krizzu added the v2 label Jun 18, 2019
@BrodaNoel
Copy link

@krizzu question: If there are not going to be breaking changes, so, why are you considering changing the version number to 2.x.x?

@krizzu
Copy link
Member Author

krizzu commented Jun 22, 2019

@BrodaNoel There are breaking changes regarding API you use (RFC available here, but no breaking changes in terms of stored data.

So you'll have to update your codebase to use new API (if you decide to move on to v2), but your users won't lose data stored.

@poltak
Copy link

poltak commented Dec 24, 2019

Are the "Storage creation options" tasks still planned for v2?
I just saw this issue was closed and those tasks not checked off, so I wasn't entirely sure of the intention. Cheers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants