Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows support on v2 master #324

Closed
wants to merge 2 commits into from
Closed

Add Windows support on v2 master #324

wants to merge 2 commits into from

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Apr 3, 2020 •
edited
Loading

Summary:

Adding Windows async-storage.

Test Plan:

  1. System requirments.
  2. Restore modules
cd packages\storage-legacy
yarn install
cd ..\..\examples\mobile
yarn install
  1. Start Metro
yarn start:windows
  1. Open examples\mobile\AsyncStorageExample.sln with VisualStudio and run.

Screenshot_20200403113108

@kaiguo kaiguo mentioned this pull request Apr 3, 2020
Closed
@kaiguo
Copy link
Contributor Author

kaiguo commented Apr 3, 2020

@htpiv FYI

@krizzu
Copy link
Member

krizzu commented Apr 4, 2020

I wish we could talk this through before any work was done 🙏
I'm putting v2 work on halt due to limited time constraint and redirecting my focus on "legacy" version.

Can we address Windows platform support there?

@kaiguo
Copy link
Contributor Author

kaiguo commented Apr 4, 2020

I wish we could talk this through before any work was done 🙏
I'm putting v2 work on halt due to limited time constraint and redirecting my focus on "legacy" version.

Can we address Windows platform support there?

OK, I will open another PR against LEGACY.

Should we check in this current PR as well? So we'll have Windows support here too when you do start working on v2.

@kaiguo
Copy link
Contributor Author

kaiguo commented Apr 6, 2020

@krizzu created another PR here: #327.

@kaiguo kaiguo changed the title Add Windows support Add Windows support on v2 master Apr 6, 2020
@krizzu krizzu changed the base branch from master to v2 April 12, 2020 16:40
@krizzu krizzu added the v2 label Apr 12, 2020
NickGerleman
NickGerleman reviewed Apr 22, 2020
View reviewed changes
packages/storage-legacy/windows/ReactNativeAsyncStorage/RNCAsyncStorage.h
#include "NativeModules.h"
#include "DBStorage.h"

using namespace winrt::Microsoft::ReactNative;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use "using namespace" in header files as this leaks to anything that includes it.

@chrisglein
Copy link
Contributor

@kaiguo with this pr accepted does this one get closed?

@kaiguo
Copy link
Contributor Author

kaiguo commented Apr 28, 2020

@kaiguo with this pr accepted does this one get closed?

Yeah closing.

@kaiguo kaiguo closed this Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickGerleman NickGerleman NickGerleman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiguo @krizzu @chrisglein @NickGerleman