Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use fast-glob for link-assets and scripts #2513

Merged
merged 1 commit into from
Sep 25, 2024
Merged

chore: use fast-glob for link-assets and scripts #2513

merged 1 commit into from
Sep 25, 2024

Conversation

thymikee
Copy link
Member

Summary:

link-assets package was using glob dependency that was not declared. Replaced it with fast-glob. Done the same for local scripts too and removed the glob entirely.

Test Plan:

Green CI, please test locally

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee thymikee merged commit 775cda6 into main Sep 25, 2024
6 of 10 checks passed
@thymikee thymikee deleted the fix/use-fast-glob branch September 25, 2024 08:27
This was referenced Oct 8, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TMisiukiewicz TMisiukiewicz TMisiukiewicz approved these changes

@szymonrybczak szymonrybczak szymonrybczak approved these changes

@adamTrz adamTrz Awaiting requested review from adamTrz adamTrz is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thymikee @TMisiukiewicz @szymonrybczak