fix(SafeSubscriber): Propagate disposal to terminal Subscriber #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the internal SafeSubscriber is disposed when an Observable is subscribed with a Subscriber or Subscriber-like object. Fixes ReactiveX#2675
benlesh
approved these changes
Feb 22, 2020
|
Sorry for my tardiness in reviewing this. I'll do it tomorrow. It LGTM, but there is one situation with interop observables I want to look into. |
cartant
approved these changes
Feb 23, 2020
|
There are some concerns here around |
benlesh
requested changes
Feb 26, 2020
|
I think foreign Subjects should be caught by these lines here, and not be wrapped in a Subscriber: rxjs/src/internal/util/toSubscriber.ts Lines 16 to 18 in 5cf26e7 |
This was referenced Jun 5, 2020
cartant
added a commit
to cartant/rxjs
that referenced
this pull request
Jun 9, 2020
|
Blocking this because of #5472 |
benlesh
added a commit
that referenced
this pull request
Jun 9, 2020
* test: add failing interop subscriber test * fix: chain safe subscribers to interop subscribers Closes #5469 #5311 #2675 * refactor: remove subscribeWith * refactor: minor change to types to clean up code. Co-authored-by: Ben Lesh <[email protected]>
|
I think this was superseded by #5472. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ensure the internal SafeSubscriber is disposed when an Observable is subscribed with a Subscriber or Subscriber-like object.
Related issue (if exists):
#2675
❤️