Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(merge): single array is not an array of sources #6211

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Apr 8, 2021

Description:

Prior to this change, the static merge behaved in a manner that was contrary to its types: it treated a single array as an array of sources. The static concat did not do this, so changing a concat to a merge or vice versa would effect wildly different behaviour if a single array was passed.

This PR adds a failing test and removes the call to argsOrArgArray - which did the sniffing and unpacking.

Regarding v7, there are a bunch of inconsistencies between concat, merge, race, combineLatest, forkJoin and zip, but most can be addressed through the application of deprecations. This change, however, addresses an inconsistency in the implementation.

Related issue (if exists): Nope

@cartant cartant requested a review from benlesh April 8, 2021 08:02
Copy link
Member

@benlesh benlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

@benlesh benlesh merged commit 4e900dc into ReactiveX:master Apr 9, 2021
@cartant cartant deleted the cartant/merge-single-array branch April 18, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants